-
1 year ago1 year ago
-
@honcho I also wanted to nuke a bunch of errant files which obviously don't look like are used by the repo.
Do I add those changes in this PR or create another one? -
1 year ago
Submitter | Evert Elias Andonov |
Target | looking-for-a-new-adventure |
Source | evert-elias-andonov/Nekomod:fixed-readme |
Reviewers
Assignees
Merge Strategy
Squash Source Branch Commits
Rewrote readme and develop files to include instructions closer to what I assume how it works.
I have no idea how the docker setup works since at quick glance it uses some syntax I don't know and relies on hardcoded image references, which is not good for local development.
Updates
README.md
:.gitmodules
file to declare them andarchiver
folder is empty.pre-commit
install logic since it has to be run only for development and only after creating a virtual environment.--interactive
flag to allcp
examples in order not to overwrite the file in case it exists already.virtualenv --upgrade-embed-wheels
because it doesn't in fact makes managing python versions easier.docs/Develop.md
->docs/develop.md
:README.md
changes but with more detailed instructions for development..vscode/extensions.json
:"ms-python.vscode-pylance"
is included along with"ms-python.python"
so no reason to rec separately."ms-toolsai.jupyter"
is same as above."rioj7.command-variable"
is not relevant anymore..vscode/settings.json
:"json,schemas"
settings because it doesn't look like json schemas are used anyway.python.linting.*
settings because they live in a separate extension now.configs/workspace.code-workspace.example
:archiver
workspaceDeletions
archiver
Is not used anymore.
.github/workflows/build.yml
Has references to
OpenYiff
github org so I assume it's not relevant anymore..vscode/launch.json
Not relevant anymore.
doc/Setup.md
Outdated and the setup instructions are not big enough to warrant a separate file.
json-schema
The repo doesn't seem to use json schema so these files are completely irrelevant.